Trapping correction module and app - #184
Conversation
|
Can we also remove |
fhagemann
left a comment
fhagemann
left a comment
There was a problem hiding this comment.
Here is my feedback from just looking at the code.
I will also try to compile and run both the module and the app to provide more feedback on that as well! :)
| // Read in the input files and make a list of hdf5 files to calibrate | ||
| if ((InputFile.GetSubString(InputFile.Length() - 4)) == "hdf5") { | ||
| HDFNames.push_back(InputFile); | ||
| cout << "hdf names loaded correctly" << endl; | ||
| } else if ((InputFile.GetSubString(InputFile.Length() - 3)) == "txt") { | ||
| cout << "Reading input file " << InputFile << endl; | ||
| cout << "WARNING: When passing a list of files, ensure that you have chosen the correct HDF5 continuous reading mode. Use the --nocontinue option to suppress continuous file reading." << endl; | ||
| MFile F; | ||
| if (F.Open(InputFile) == false) { | ||
| cout << "Error: Failed to open input file." << endl; | ||
| } else { |
There was a problem hiding this comment.
Are there examples for a txt input file?
There was a problem hiding this comment.
The txt files give the lineshift across depth but they need to be fit to sim CCE curves in python to get the trapping param files so I'm not sure how helpful these will be until someone else needs to learn to produce trapping params. Just probably not something we need incorporated in nuclearizer atm.
There was a problem hiding this comment.
Ah sorry, I was refering to a txt file used to pass multiple filenames to the app.
Would that just be
gse_filename1.hdf5
gse_filename2.hdf5
gse_filename3.hdf5
...
?
|
The example file in 
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
3 participants
Contains a new module for applying depth-based charge trapping correction to individual hit energies along with modules with GUI options and GUI expos. The branch also includes an app for characterizing trapping with Cs-137 data. The trapping correction module requires a csv parameter file as input:
detector_0_trapping_parameters.csv
This file can also be found in resource/dee